Bala.FA has posted comments on this change. Change subject: gluster: Added VDSM verb to stop gluster related processes ......................................................................
Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/api.py File vdsm/gluster/api.py: Line 53: ) Line 54: Line 55: _stopAllProcessesPath = utils.CommandPath( Line 56: "stop-all-gluster-processes.sh", Line 57: "/usr/share/glusterfs/scripts/stop-all-gluster-processes.sh", > I think so. But may be we should verify with gluster team as well. Please confirm this. Line 58: ) Line 59: Line 60: Line 61: GLUSTER_RPM_PACKAGES = ( Line 276: _stopAllProcessesPath Is there any reason why the script is not set with execute permission? https://gerrit.ovirt.org/#/c/43821/3/vdsm/gluster/exception.py File vdsm/gluster/exception.py: Line 607: GlusterStopProcessesFailedException You should move it to gluster general -- To view, visit https://gerrit.ovirt.org/43821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id686e098b323eededcf1f89de331a1d524274995 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Darshan Narayana Murthy <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
