Milan Zamazal has posted comments on this change. Change subject: periodic: add executor-compatible naming ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/48193/6//COMMIT_MSG Commit Message: Line 8: Line 9: We want to make as easy as possible to debug Line 10: thread leaks from executor, so we make the periodic Line 11: framework support names for Operations, using the Line 12: way Executor expects them. What's the executor-compatible naming? Is NAME utilized anywhere outside periodic.py, perhaps in another patch (I can't see it in the current source code)? Line 13: Line 14: Change-Id: If8d1180b727571cce34e8304ac48390ed2135f79 Line 15: Bug-Url: https://bugzilla.redhat.com/1250839 Line 16: Backport-To: 3.6 https://gerrit.ovirt.org/#/c/48193/6/vdsm/virt/periodic.py File vdsm/virt/periodic.py: Line 262: return '<VmDispatcher operation=%s at 0x%x>' % ( Line 263: self._create, id(self) Line 264: ) Line 265: Line 266: __repr__ = __str__ Why renaming __repr__ to __str__ and then defining this alias here? Wasn't having just __repr__ method enough? Line 267: Line 268: Line 269: class _RunnableOnVm(object): Line 270: -- To view, visit https://gerrit.ovirt.org/48193 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d1180b727571cce34e8304ac48390ed2135f79 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
