Nir Soffer has posted comments on this change. Change subject: iscsi: Fix credentials initialization when not using CHAP ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/48483/2/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 229: iface = _resolveIscsiIface(conDict.get('ifaceName', None), Line 230: conDict.get('initiatorName', None), Line 231: conDict.get('netIfaceName', None)) Line 232: Line 233: # NOTE: ChapCredentials must match the way we initialze username and > typo Where? Line 234: # password when reading session info in iscsi.readSessionInfo(). Empty Line 235: # or missing username or password are stored as None. Line 236: Line 237: username = conDict.get('user') https://gerrit.ovirt.org/#/c/48483/2/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 162: iface = IscsiInterface(iface, netIfaceName=netdev) Line 163: portal = IscsiPortal(ip, port) Line 164: target = IscsiTarget(portal, tpgt, iqn) Line 165: Line 166: # NOTE: ChapCredentials must match the way we initialze username and > typo Where? Line 167: # password when receiving request from engine in Line 168: # hsm._connectionDict2ConnectionInfo(). Line 169: # iscsi reports empty user/password as "<NULL>" (RHEL5) or "(null)" Line 170: # (RHEL6); empty values are stored as None. -- To view, visit https://gerrit.ovirt.org/48483 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65e1177bc33998b8eba34b0fd04ec62cf8bf1a2c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
