Petr Horáček has posted comments on this change. Change subject: hooks: ovs: better rollback ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/46907/11/vdsm_hooks/ovs/ovs_before_network_setup.py File vdsm_hooks/ovs/ovs_before_network_setup.py: Line 146: ovs_nets, non_ovs_nets, ovs_bonds, non_ovs_bonds = \ Line 147: _separate_ovs_nets_bonds(networks, bondings, running_config) Line 148: _configure(ovs_nets, ovs_bonds, running_config) Line 149: setup_nets_config['request']['bondings'] = non_ovs_bonds Line 150: setup_nets_config['request']['networks'] = non_ovs_nets > I meant doing this dictionary update (which you do twice) in a function wit Done Line 151: hooking.log('Hook finished, returning non-OVS networks and bondings ' Line 152: 'back to VDSM: %s' % setup_nets_config) Line 153: Line 154: hooking.write_json(setup_nets_config) -- To view, visit https://gerrit.ovirt.org/46907 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
