Milan Zamazal has posted comments on this change. Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter ......................................................................
Patch Set 1: (1 comment) We now check for unicodes and convert them to strings. https://gerrit.ovirt.org/#/c/48542/1/vdsm/logUtils.py File vdsm/logUtils.py: Line 96: value = value.decode('utf-8', 'replace') Line 97: result += u'%s=`%s`' % (key, value) Line 98: if isinstance(msg, str): Line 99: msg = msg.decode('utf-8', 'replace') Line 100: result += u'::%s' % msg > OK, I'll change the conversion direction. Done Line 101: return (result, kwargs) Line 102: Line 103: Line 104: class TracebackRepeatFilter(logging.Filter): -- To view, visit https://gerrit.ovirt.org/48542 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1930817ade1799b218913348ffa099aab2211ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
