Antoni Segura Puimedon has posted comments on this change. Change subject: 1 of 2 Add network logs for VDSM network commands and file operations. ......................................................................
Patch Set 4: (6 inline comments) .................................................... Commit Message Line 3: AuthorDate: 2012-09-02 03:26:37 +0200 Line 4: Commit: Antoni S. Puimedon <[email protected]> Line 5: CommitDate: 2012-09-04 15:37:50 +0200 Line 6: Line 7: 1 of 2 Add network logs for VDSM network commands and file operations. Done Line 8: Line 9: This patch is the first of a series with the aim of expanding the logging done Line 10: in network and traffic control. In order to do so, it uses Line 11: vdsm.storage.misc.execCmd. Line 9: This patch is the first of a series with the aim of expanding the logging done Line 10: in network and traffic control. In order to do so, it uses Line 11: vdsm.storage.misc.execCmd. Line 12: Line 13: ConfigNetwork and tc logging levels are increased by using execCmd and adding Done Line 14: more debug info on file operations. Line 15: Line 16: Bug-Id: https://bugzilla.redhat.com/851839 Line 17: Change-Id: I825431e4a2cbb603fea2b5472b072e5d6a3862e9 .................................................... File vdsm/configNetwork.py Line 61: Line 62: def ifup(iface): Line 63: "Bring up an interface" Line 64: rc, out, err = execCmd([constants.EXT_IFUP, iface], raw=True) Line 65: if out.strip(): I kept it because this output is logged in the info level that goes always into the logs, for the sysadmins. The debug level (execCmd) in theory is only logged when debugging the software. If I misunderstood it I'll of course remove from line 65 to 68. Line 66: logging.info(out) Line 67: if err.strip(): Line 68: logging.warn(err) Line 69: return rc Line 153: def _removeFile(filename): Line 154: """Remove file, umounting ovirt config files if needed.""" Line 155: Line 156: mounts = open('/proc/mounts').read() Line 157: if ' /config ext3' in mounts and ' %s ext3' % filename in mounts: I'll keep it in mind for another patch. Line 158: execCmd([constants.EXT_UMOUNT, '-n', filename]) Line 159: utils.rmFile(filename) Line 160: logging.debug("Removed file %s", filename) Line 161: Line 1120: Line 1121: _netinfo = netinfo.NetInfo() Line 1122: Line 1123: for bond, bondAttrs in bondings.iteritems(): Line 1124: logger.debug("Creating/Editing bond %s with attributes %s", bond, Done Line 1125: bondAttrs) Line 1126: Line 1127: brNets = list(_netinfo.getBridgedNetworksForIface(bond)) Line 1128: # Only one bridged-non-VLANed network allowed on same nic/bond .................................................... File vdsm/tc.py Line 21: from collections import namedtuple Line 22: Line 23: import ethtool Line 24: Line 25: from storage.misc import execCmd Right, glitch of the patch order inversion. Line 26: from vdsm.constants import EXT_TC, EXT_IFCONFIG Line 27: Line 28: ERR_DEV_NOEXIST = 2 Line 29: -- To view, visit http://gerrit.ovirt.org/7662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I825431e4a2cbb603fea2b5472b072e5d6a3862e9 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Meni Yakove <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
