Yaniv Kaul has posted comments on this change. Change subject: block: add blkdiscard on zero image ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/35631/1/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 219: size = multipath.getDeviceSize(lvm.lvDmDev(sdUUID, volUUID)) Line 220: Line 221: try: Line 222: misc.ddWatchCopy("/dev/zero", path, aborting, size) Line 223: utillinux.blkdiscard(path) Are we discarding AFTER we perform the 'dd'? What's the point? Line 224: except Exception as e: Line 225: log.exception('zeroing operation failed') Line 226: raise se.VolumesZeroingError(path) Line 227: -- To view, visit https://gerrit.ovirt.org/35631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e059c556c550440727b36b8af8e5dfc29ce2ccb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
