Moti Asayag has posted comments on this change. Change subject: Added _execGlusterXml() ......................................................................
Patch Set 8: (1 inline comment) .................................................... File vdsm/gluster/exception.py Line 93: Line 94: Line 95: class GlusterCmdFailedException(GlusterGeneralException): Line 96: code = 4107 Line 97: message = "command failed" a minor comment here - why this message doesn't start with an uppercase as the rest? Line 98: Line 99: Line 100: # Volume Line 101: class GlusterVolumeException(GlusterException): -- To view, visit http://gerrit.ovirt.org/6999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I385f992005d446b417be84eb7ff484e4edf6e5b6 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Bala.FA <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Bala.FA <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Timothy Asir <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
