Nir Soffer has posted comments on this change. Change subject: v2v: add import thread as a member ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/48600/1/vdsm/v2v.py File vdsm/v2v.py: Line 326: def __init__(self, vminfo, job_id, irs): Line 327: ''' Line 328: do not use directly, use a factory method instead! Line 329: ''' Line 330: self.thread = None Lets keep this private, and add a wait() method to join the thread. Line 331: self._vminfo = vminfo Line 332: self._id = job_id Line 333: self._irs = irs Line 334: -- To view, visit https://gerrit.ovirt.org/48600 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30f21c00f520f67d199c39376cbaf053025a60c2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
