Nir Soffer has posted comments on this change. Change subject: v2v: add fake virt-v2v process for testing without virt-v2v ......................................................................
Patch Set 12: Code-Review+1 (2 comments) Thanks Shahar, this is important addition to v2v. Now we can easily refactor this code. https://gerrit.ovirt.org/#/c/47738/12/tests/v2vTests.py File tests/v2vTests.py: Line 184: self.image_id_a = '00000000-0000-0000-0000-000000000001' Line 185: self.volume_id_a = '00000000-0000-0000-0000-000000000002' Line 186: self.image_id_b = '00000000-0000-0000-0000-000000000003' Line 187: self.volume_id_b = '00000000-0000-0000-0000-000000000004' Line 188: self.url = 'vpx://adminr%[email protected]/ovirt/0.0.0.0?no_verify=1' Nice! Line 189: Line 190: def testGetExternalVMs(self): Line 191: if not v2v.supported(): Line 192: raise SkipTest('v2v is not supported current os version') Line 318: 'domainID': self.domain_id, Line 319: 'disks': [{'imageID': self.image_id_a, Line 320: 'volumeID': self.volume_id_a}, Line 321: {'imageID': self.image_id_b, Line 322: 'volumeID': self.volume_id_b}]} Nice! Line 323: ivm = v2v.ImportVm.from_libvirt(self.url, 'root', 'mypassword', Line 324: vminfo, self.job_id, FakeIRS()) Line 325: ivm._run_command = ivm._run Line 326: ivm.start() -- To view, visit https://gerrit.ovirt.org/47738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If062a1136921af19a2ffcb4d147611bbc9cf5464 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
