Francesco Romani has posted comments on this change. Change subject: exception: Add exceptions for vdsm.define errors ......................................................................
Patch Set 5: Code-Review-1 -1 because of a question this comment is not necessarily related to this patch, but I'm not sure where to attach it. I like this patchset, but I don't fully understand the relation with the response module, which is a client of lib/vdsm/define::errCode.py (actually a thin wrapper over it). How do you plan to interact with response.py? -- To view, visit https://gerrit.ovirt.org/48871 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01b736c06414a3af758ad6bdabddb6c25b620756 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches