Nir Soffer has posted comments on this change. Change subject: mkimage: setup right permissions before mkisofs ......................................................................
Patch Set 4: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/48538/4/vdsm/mkimage.py File vdsm/mkimage.py: Line 133: # mkisofs/genisoimage will truncate the content and keep the Line 134: # permissions. Line 135: Line 136: if os.path.exists(isopath): Line 137: logging.warn('iso file %s already present, erasing') - It would be useful to actually log the isopath :-) - "exists" is more clear than "already present", and "removing" is better then "erasing", as these are the terms we use elsewhere. - Use logging.warning - we have both warn and warning in the code. warning is the official name, and is an alias for backward compatibility. Line 138: rmFile(isopath) Line 139: Line 140: fd = os.open(isopath, os.O_CREAT | os.O_RDONLY | os.O_EXCL, 0o640) Line 141: os.close(fd) -- To view, visit https://gerrit.ovirt.org/48538 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc971a39ae2a8eaf7af934bb0922647e4676d03f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
