Nir Soffer has posted comments on this change. Change subject: vm: add test for nic unplug wait ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/49104/7/tests/vmTests.py File tests/vmTests.py: Line 1283: path='test_path', diskType=DISK_TYPE.NETWORK) Line 1284: drive_block = Drive({}, log=logging.getLogger(''), index=0, iface="", Line 1285: path="/block_path", diskType=DISK_TYPE.BLOCK) Line 1286: interface = Interface({}, log=logging.getLogger(''), macAddr="macAddr", Line 1287: device='bridge') Marcin, if we initialize interface name here: interface = Interface({}, log=logging.getLogger(''), macAddr="macAddr", device='bridge', name="foo") Does it eliminate the need for _make_name() in https://gerrit.ovirt.org/#/c/48473/16/vdsm/virt/vmdevices/network.py ? Line 1288: Line 1289: @MonkeyPatch(vm, "config", make_config([ Line 1290: ("vars", "hotunplug_timeout", "0.25"), Line 1291: ("vars", "hotunplug_check_interval", "0.1") -- To view, visit https://gerrit.ovirt.org/49104 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
