Francesco Romani has posted comments on this change. Change subject: v2v: add try/except to get_external_vms ......................................................................
Patch Set 1: Code-Review-1 (1 comment) I'm totally fine with the concept, not sure how this patch achieves that. https://gerrit.ovirt.org/#/c/49507/1/vdsm/v2v.py File vdsm/v2v.py: Line 172: for disk in params['disks']: Line 173: _add_disk_info(conn, disk) Line 174: vms.append(params) Line 175: except InvalidVMConfiguration as e: Line 176: logging.error('error parsing domain: %s', e) which function/method can raise InvalidVMConfiguration? I mean: _add_general_info could, and indeed we have try/except guard. What besides that? Line 177: return {'status': doneCode, 'vmList': vms} Line 178: Line 179: Line 180: def convert_external_vm(uri, username, password, vminfo, job_id, irs): -- To view, visit https://gerrit.ovirt.org/49507 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec63dea83ec1805cf08d35be7c078edfd2f70966 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
