Daniel Erez has uploaded a new change for review. Change subject: vm: snapshot - enabling memory snapshot for diskless VM ......................................................................
vm: snapshot - enabling memory snapshot for diskless VM Taking a memory snapshot of a VM without disks should be supported (or merely with Cinder/LUN disks for that matter). Hence, removing the early return on 'VM -> snapshot' in case 'newDrives' is empty. Instead, proper logging will be added on consecutive patches. Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Bug-Url: https://bugzilla.redhat.com/1287066 Signed-off-by: Daniel Erez <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 0 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/49535/1 diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py index 8ec8b1d..8503f64 100644 --- a/vdsm/virt/vm.py +++ b/vdsm/virt/vm.py @@ -3134,11 +3134,6 @@ # safely access the blockDev property until after prepareVolumePath vmDrives[vmDevName] = vmDrive - # If all the drives are the current ones, return success - if len(newDrives) == 0: - self.log.debug('all the drives are already in use, success') - return {'status': doneCode} - preparedDrives = {} for vmDevName, vmDevice in newDrives.iteritems(): -- To view, visit https://gerrit.ovirt.org/49535 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia540fa9009f627f7a2943ef393084eee3f047bf5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
