Adam Litke has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
......................................................................
Patch Set 4: (2 inline comments)
Almost there. Just want to ask Dan to review...
....................................................
File vdsm/storage/taskManager.py
Line 113: taskID)
Line 114: self.log.debug("Return: %s", subRes)
Line 115: return subRes
Line 116:
Line 117: def getAllTasks(self, tag=[]):
Hopefully Dan can weigh in on this. I don't want to mis-characterize his views
on using an array for the tag argument. If we keep the array, please change
tag to tags to convey the plurality.
Line 118: """
Line 119: Return Tasks for all public tasks if param tag is empty,
Line 120: else return tasks those tags are in param tag.
Line 121: """
Line 132: self.log.warn("Unknown task %s. Maybe task was
already "
Line 133: "cleared.", taskID)
Line 134:
Line 135: subRes.update(glusterTasks.getTasks(tag))
Line 136:
Thanks. This is much better.
Line 137: self.log.debug("Return: %s", subRes)
Line 138: return subRes
Line 139:
Line 140: def unloadTasks(self, tag=None):
--
To view, visit http://gerrit.ovirt.org/7579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
