Edward Haas has posted comments on this change. Change subject: hooks: ovs: drop initial bonds' slaves IP config ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/50100/2/vdsm_hooks/ovs/ovs_before_network_setup_ip.py File vdsm_hooks/ovs/ovs_before_network_setup_ip.py: Line 171: bond There is a bit of duplicate code in it. What about: bonds_to_drop_ip_from = (bond for bond, attrs in six.iteritems(bonds) if 'remove' not in attrs) for bond in bonds_to_drop_ip_from: nics_to_drop_ip_from = (set(attrs.get('nics')) - set(init_bonds[bond].get('nics'))) if bond in init_bonds else set(attrs.get('nics')) for nic in nics: _drop_ip_config(nic) -- To view, visit https://gerrit.ovirt.org/50100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6584bdd8ee544880a77fc9d3e57e523d51e23532 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
