Nir Soffer has posted comments on this change. Change subject: storage: Introduction to transfer.py ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/50014/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 532: # @ticketUUID: Ticket UUID Line 533: # Line 534: # @ops: Comma-delimited operation list (e.g. "get, put") Line 535: # Line 536: # @expiration: Expiration epoch > This also depends on engine and vdsm being in time sync. Do we want this p Sounds like a better idea, so this should be "timeout" in seconds. Vdsm will pass the timeout to imaged, and imaged will calculate a deadline. Line 537: # Line 538: # @spUUID: Storage Pool UUID Line 539: # Line 540: # @sdUUID: Storage Domain UUID Line 540: # @sdUUID: Storage Domain UUID Line 541: # Line 542: # @imgUUID: Image UUID Line 543: # Line 544: # @volUUID: Volume UUID > I actually like the prepareImage bundled in the verb. When would you ever We are moving to smaller and simpler interfaces in vdsm, and giving engine more control, and this seems like the opposite direction. We already an api for preparing images, so why do we need to create a new version of it? Also, maybe the image is already prepared, and we want to start a session for it? For example, we can start multiple read only session for the same image, for serving multiple clients. Line 545: # Line 546: # Since: 4.17.4 Line 547: ## Line 548: {'command': {'class': 'Host', 'name': 'startImageTransferSession'}, Line 576: # Extend an image upload data transfer session. Line 577: # Line 578: # @ticketUUID: Ticket UUID Line 579: # Line 580: # @expiration: Expiration epoch > Reset session to @expiration seconds from now? Call it timeout in this case, meaning extending the timeout. Line 581: # Line 582: # Since: 4.17.4 Line 583: ## Line 584: {'command': {'class': 'Host', 'name': 'extendImageTransferSession'}, -- To view, visit https://gerrit.ovirt.org/50014 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b9ded4bde73b1ab504cae50d2cea726d4f77e51 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
