Nir Soffer has posted comments on this change. Change subject: executor: Rename self._callabale to self._task ......................................................................
Patch Set 1: Piotr, jsonrpc point of view is not relevant the internals of the executor. The executor manage a task queue and execute the tasks (execute_task, get_next_task, etc.), so we should be consistent internally. The api is using callable to make it clear that you can submit a function or a callable class, and you don't need a special class instance. We are keeping the term callable when getting stuff from the queue, since this is what was queued later. We could rename task to callable everywhere, but I don't think that get_next_callable or execute_callable make sense. If we want to avoid the mismatch, we should rename callable to task and document the meaning of the task argument in submit. -- To view, visit https://gerrit.ovirt.org/50228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
