Nir Soffer has posted comments on this change. Change subject: v2v: externalVMList Xen+Kvm support ......................................................................
Patch Set 17: Code-Review-1 (2 comments) Fake libvirt connection looks wrong. https://gerrit.ovirt.org/#/c/48672/17/tests/v2vTests.py File tests/v2vTests.py: Line 131: def lookupByName(self, name): Line 132: for vm in self._vms: Line 133: if vm.name == name: Line 134: return vm Line 135: return None Does libvirt return None, or raise libvirtError? Line 136: Line 137: def lookupByID(self, id): Line 138: for vm in self._vms: Line 139: if vm.id == id: Line 137: def lookupByID(self, id): Line 138: for vm in self._vms: Line 139: if vm.id == id: Line 140: return vm Line 141: return None Does libvirt return None, or raise libvirtError? Line 142: Line 143: def storageVolLookupByPath(self, name): Line 144: return LibvirtMock.Volume() Line 145: -- To view, visit https://gerrit.ovirt.org/48672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4 Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Milan Zamazal <mzama...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches