Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Correctly apply MTU values on networks ......................................................................
net: Correctly apply MTU values on networks Two issues have been resolved by this change: - New networks with no MTU specification are being set by default with their connected device (bond, vlan, nic) mtu (which does not have to be 1500). Fixed by detecting when no MTU is specified in the configuration, and adding the default (1500) explicitly. The assumption of a single default mtu when one is not specified in the setup is wrong, causing in some cases an unnecessary restoration of networks during network restoration. - Test fix: The NIC/s mtu should be set to the maximum mtu of the remaining networks. Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Signed-off-by: Edward Haas <edwa...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/50397 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M lib/vdsm/kernelconfig.py M lib/vdsm/network/api.py M tests/configNetworkTests.py M tests/functional/networkTests.py 4 files changed, 83 insertions(+), 30 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/50397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
