Nir Soffer has posted comments on this change. Change subject: storage: add getHostId to DomainMonitor ......................................................................
Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/50630/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-12-16 15:41:26 -0500 Line 6: Line 7: storage: add getHostId to DomainMonitor Line 8: Line 9: Some SDM verbs need to acquire the domainLock during their job. In Trailing whitespace Line 10: order to do this they must be passed the domain's hostId property. An Line 11: easy way to expose this is to add a getHostId method to the Line 12: DomainMonitor. Line 13: Line 8: Line 9: Some SDM verbs need to acquire the domainLock during their job. In Line 10: order to do this they must be passed the domain's hostId property. An Line 11: easy way to expose this is to add a getHostId method to the Line 12: DomainMonitor. Explain why we don't use: getPools()[0].id Line 13: Line 14: Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c -- To view, visit https://gerrit.ovirt.org/50630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
