Nir Soffer has submitted this change and it was merged.
Change subject: storage: Rename storageConstants.py to constants.py
......................................................................
storage: Rename storageConstants.py to constants.py
The SDM work is beginning an effort to reorganize storage constants.
Currently constants are peppered throughout the various storage modules.
Getting access to these constants introduces complex module
interdependencies which can lead to circular import dependencies.
In this first step, rename storageConstants.py to constants.py and make
necessary adjustments to the code which currently imports this module.
The new name is shorter and does not have the redundant 'storage' as
part of its name. Future patches will move constants into this module.
To prevent clashes with vdsm.constants, we always import storage
constants like this:
from storage.constants import FOO_BAR
Change-Id: I74684fdf63fb08573dc2068dcfb32ba5febac82b
Signed-off-by: Adam Litke <ali...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50633
Reviewed-by: Nir Soffer <nsof...@redhat.com>
Continuous-Integration: Jenkins CI
---
M debian/vdsm.install
M vdsm.spec.in
M vdsm/storage/Makefile.am
R vdsm/storage/constants.py
M vdsm/storage/hsm.py
M vdsm/storage/misc.py
M vdsm/storage/sp.py
7 files changed, 10 insertions(+), 7 deletions(-)
Approvals:
Adam Litke: Verified; Looks good to me, but someone else must approve
Nir Soffer: Looks good to me, approved
Jenkins CI: Passed CI tests
--
To view, visit https://gerrit.ovirt.org/50633
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I74684fdf63fb08573dc2068dcfb32ba5febac82b
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Ala Hino <ah...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Amit Aviram <aavi...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Freddy Rolland <froll...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Idan Shaby <ish...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
