Douglas Schilling Landgraf has posted comments on this change. Change subject: BZ#856167 - Store engine CA cert in enginecacert.pem ......................................................................
Patch Set 2: Looks good to me, but someone else must approve (1 inline comment) .................................................... File vdsm_reg/deployUtil.py.in Line 1447: dt = datetime.datetime.now() Line 1448: backupTime = dt.strftime("%Y-%m-%d_%H%M%S") Line 1449: Line 1450: for pemFile in certs: Line 1451: if os.path.exists(pemFile): hopefully the certs will exists from the before certPaths(''), line 1464 but good call. Line 1452: certName = os.path.basename(pemFile) Line 1453: dirName = os.path.dirname(pemFile) Line 1454: Line 1455: bkpCertName = dirName + "/bkp-" + backupTime + '_' + certName -- To view, visit http://gerrit.ovirt.org/8038 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127bf44cbcde90f7dae26a3bd3127f3eac2ca53c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Burns <mbu...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches