Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-upgrade: stop vdsm when complete upgrade ......................................................................
Patch Set 3: (1 inline comment) .................................................... File vdsm_reg/vdsm-upgrade Line 135: if ret == 0: Line 136: # Stop vdsm to avoid any communication with Engine before the reboot happens Line 137: out, err, ret = deployUtil._logExec([constants.EXT_SERVICE, 'vdsmd', 'stop']) Line 138: else: Line 139: msg = "<BSTRAP component='RHEL_INSTALL' status='FAIL' message='vdsm daemon" \ in that case I will move to status="WARN" and remove from the msg "please verify" Line 140: " is down before we stop it for upgrade, please verify!'/>" Line 141: logging.debug(msg) Line 142: print(msg) Line 143: -- To view, visit http://gerrit.ovirt.org/8029 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifa889880c7f02c7ecc13daa595873c1ad3e15c67 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
