Nir Soffer has submitted this change and it was merged.
Change subject: executor: Fix the task-callable mismtach
......................................................................
executor: Fix the task-callable mismtach
Executor is executing queue tasks, but the public api is dealing with
callable and timeout. These leak into the executor internals, and cause
confusion when we log the executor state.
Now we pack the callable and the timeout in a Task namedtuple, fixing
the mismatch, and providing more information when logging the task in
Worker.__repr__.
Task(callable=<function func at 0x7fd84f3ec500>, timeout=7)
Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Signed-off-by: Nir Soffer <nsof...@redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50228
Reviewed-by: Francesco Romani <from...@redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczew...@gmail.com>
---
M lib/vdsm/executor.py
1 file changed, 16 insertions(+), 13 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/50228
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id50a4175bc9cb27b9e432a2c871b1ba98cf625c8
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
