Dan Kenigsberg has posted comments on this change.
Change subject: net: set netconf/* owner to 'vdsm'
......................................................................
Patch Set 1: Code-Review-1
(2 comments)
To make the unit test pass, please monkey-patch pwd.getpwnam()
ERROR: testSaveAndDelete (netconfpersistenceTests.NetConfPersistenceTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/var/lib/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/tests/netconfpersistenceTests.py",
line 77, in testSaveAndDelete
persistence.save()
File
"/var/lib/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/vdsm/netconfpersistence.py",
line 123, in save
self._setConfig(attrs, self._networkPath(network))
File
"/var/lib/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/lib/vdsm/netconfpersistence.py",
line 169, in _setConfig
vdsm_uid = pwd.getpwnam('vdsm').pw_uid
KeyError: 'getpwnam(): name not found: vdsm'
https://gerrit.ovirt.org/#/c/50984/1/lib/vdsm/netconfpersistence.py
File lib/vdsm/netconfpersistence.py:
Line 168: RHEV-H
please avoid using trademarks (such as RHEV). the proper name is ovirt-node.
(here and in the commit message)
Line 169: 'vdsm'
Please use constants.py.VDSM_USER
--
To view, visit https://gerrit.ovirt.org/50984
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65725c698bdd3cd3a51a3327b33ce9b16292820a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwa...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
