Nir Soffer has posted comments on this change. Change subject: register: handle non uuid machines ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/47385/2/lib/vdsm/tool/register.py File lib/vdsm/tool/register.py: Line 258: self.uuid = self.vdsm_uuid Line 259: else: Line 260: self.uuid = getHostUUID(legacy=False) Line 261: Line 262: if self.uuid is None: > the BZ asks only to improve the text in case no uuid is found. You are doin I agree with Dan, just improve the error to make the issue clear. We can consider handling automatically later. Line 263: self.uuid = str(uuid.uuid4()) Line 264: self.logger.debug("Generated UUID: {0}".format(self.uuid)) Line 265: Line 266: self.url_reg += "&uniqueId={u}".format(u=self.uuid) -- To view, visit https://gerrit.ovirt.org/47385 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9429e46895a73178cf459d5ced5d39499e993922 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
