Dan Kenigsberg has posted comments on this change. Change subject: net: mtu should be reported as a string through caps ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/51164/3/lib/vdsm/netinfo/__init__.py File lib/vdsm/netinfo/__init__.py: Line 98: return networking Line 99: Line 100: Line 101: def get_with_engine36_compatibility(): Line 102: # REQUIRED_FOR engine < 3.7 > I have no opinion on this, Dan? Neither do I see a difference. Line 103: return _stringify_mtus(get()) Line 104: Line 105: Line 106: def _stringify_mtus(netinfo_data): https://gerrit.ovirt.org/#/c/51164/3/vdsm/caps.py File vdsm/caps.py: Line 634: netinfo_data > I did it to express what data is being updated. sorry, I don't understand the explanation. -- To view, visit https://gerrit.ovirt.org/51164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I719ed889bfae763ce7cbed4f2aab3f6134ba2865 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
