Nir Soffer has posted comments on this change. Change subject: guestagent: Speed up xml character filtering ......................................................................
Patch Set 3: (3 comments) Yaniv, I don't think we should care about "discouraged" characters. If we find that our xmlrpc stack is failing because of them we will add them. https://gerrit.ovirt.org/#/c/50945/3/tests/guestagentTests.py File tests/guestagentTests.py: Line 89: @expandPermutations Line 90: class TestFiltering(TestCaseBase): Line 91: Line 92: @permutations([ Line 93: [u"\u0009-\u000a"], > testing only the edges is fine. but having a range-looking string threw me I'l make it more clear in the next version. Line 94: [u"\u000d"], Line 95: [u"\u0020-\u007e"], Line 96: [u"\u0085"], Line 97: [u"\u00a0-\ud7ff"], https://gerrit.ovirt.org/#/c/50945/3/vdsm/virt/guestagent.py File vdsm/virt/guestagent.py: Line 1: # Line 2: # Copyright 2011-2014 Red Hat, Inc. > If there's no other change needed I'd rather have this updated in a follow Will fix Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by Line 6: # the Free Software Foundation; either version 2 of the License, or Line 49: # ranges: Line 50: # Line 51: # [#x1-#x8] | [#xB-#xC] | [#xE-#x1F] | [#x7F-#x84] | [#x86-#x9F] Line 52: # Line 53: # The following ranges are the results of substructing the the RestrictedChar > 'the the' -> 'the' Thanks, will fix in next version. Line 54: # ranges from Char ranges, and adding 0x00, FFFE, and FFFF. Any character in Line 55: # these ranges will be replaced by the unicode replacement character. Line 56: Line 57: _FILTERED_CHARS = ( -- To view, visit https://gerrit.ovirt.org/50945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic7990dbe9787089b15f63e89de284c8695472b66 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
