Vinzenz Feenstra has posted comments on this change. Change subject: guestagent: Simplify and modernize object filtering ......................................................................
Patch Set 5: No this is not true - We should always filter it - Because in the end the engine might break when it tries to unescape the filtered strings. I have thought so as well at first, but what we really do, is to ensure that the data is valid unicode. If it is not, we are risking that somewhere in the engine the strings get unescaped from json to java strings and tries to process them - That can have very bad side effects. So no, we do not want to remove the filtering for JSONRPC anymore -- To view, visit https://gerrit.ovirt.org/51039 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I753d97ffe992400728aebed0352661306a1619c7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Kaul <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
