Vinzenz Feenstra has posted comments on this change. Change subject: cpuinfo: idea - moving predicates to methods ......................................................................
Patch Set 2: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/51428/2/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 154: Line 155: @logDecorator Line 156: def getHardwareInfo(self, *args, **kwargs): Line 157: arch = cpuarch.real() Line 158: if cpuarch.is_x86(arch): => arch.is_x86() Line 159: from vdsm.dmidecodeUtil import getHardwareInfoStructure Line 160: return getHardwareInfoStructure() Line 161: elif cpuarch.real().is_ppc(): Line 162: from vdsm.ppc64HardwareInfo import getHardwareInfoStructure Line 157: arch = cpuarch.real() Line 158: if cpuarch.is_x86(arch): Line 159: from vdsm.dmidecodeUtil import getHardwareInfoStructure Line 160: return getHardwareInfoStructure() Line 161: elif cpuarch.real().is_ppc(): wrong => arch.is_ppc() Line 162: from vdsm.ppc64HardwareInfo import getHardwareInfoStructure Line 163: return getHardwareInfoStructure() Line 164: else: Line 165: # not implemented over other architecture -- To view, visit https://gerrit.ovirt.org/51428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I066575e98ff3778d915255f6c8a68667238fc6fb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
