Shu Ming has posted comments on this change.
Change subject: Add deathSignal options to better popen
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/betterPopen/createprocess.c
Line 310:
Line 311: if (deathSignal) {
Line 312: /* death signal sync point */
Line 313: if (read(errnofd[0], &childErrno, sizeof(int)) !=
sizeof(int)) {
Line 314: PyErr_SetString(PyExc_OSError, strerror(childErrno));
It is more robust to check the return code of read() to know what the status
of read() system is. Normally, EAGIN and EINTR should be checked.
Line 315: goto fail;
Line 316: }
Line 317:
Line 318: if (childErrno != 0) {
--
To view, visit http://gerrit.ovirt.org/6241
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
