Edward Haas has posted comments on this change. Change subject: test: Do not force verbose test output ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/51772/1//COMMIT_MSG Commit Message: Line 8: Line 9: Let the user explicitly enable verbose. Line 10: Line 11: Tests, especially unit tests, are interesting when they fail Line 12: and not when they pass. > No, they are interesting also when they pass, for example I like to see why IMO skipping is a workaround, a clean test should either fail or pass. If a test is skipped, it better be because one marked it explicitly and not because an unexpected or unstable event. When practicing TDD, tests are ran frequently and verbosity is noise, especially if there are a lot of tests. What would you recommend to change here? Leaving the default to be verbose? Line 13: Line 14: To run with verbose output, use: 'NOSE_VERBOSE=3' Line 15: Example: 'make check NOSE_VERBOSE=3' Line 16: -- To view, visit https://gerrit.ovirt.org/51772 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d2210b7497b2a21618ebf4a3358507d8d8ced33 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
