Nir Soffer has posted comments on this change. Change subject: lib: use weakmethod to break reference cycles ......................................................................
Patch Set 10: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/51630/10/lib/vdsm/libvirtconnection.py File lib/vdsm/libvirtconnection.py: Line 165 Line 166 Line 167 Line 168 Line 169 Please add the missing weakmethod now, before backporting partial patch to 2 other branches. -- To view, visit https://gerrit.ovirt.org/51630 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06607e63d222bf3f8037f2bda115b48feb94cb1c Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
