Douglas Schilling Landgraf has posted comments on this change.
Change subject: vdsmd.init: verify if libvirt socket file exists
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/vdsmd.init.in
Line 401: # this workaround should be removed.
Line 402:
Line 403: for i in {1..50}
Line 404: do
Line 405: if [[ -S /var/run/libvirt/libvirt-sock ]] && [[ `pgrep
libvirtd` ]]; then
> was this actually verified?
Yes.
Simple test, from bash (without need to reboot):
# cat test.sh
if [[ -S /var/run/libvirt/libvirt-sock ]] && [[ `pgrep libvirtd` ]]; then
echo "libvirt is running"
fi
# bash test.sh
libvirt is running
# killall -9 libvirtd
# bash test.sh
#
> [[ -S /var/run/libvirt/libvirt-sock ]] && pgrep libvirtd > /dev/null 2>&1
> would have been syntactically better.
Well, you are the maintainer, you decide which style is better to maintain....
> p.s. you know how much I love short lines...
Indeed, what about add a git hook to fail git commit with patches > 80 chars?
Line 406: return 0
Line 407: fi
Line 408: sleep 0.2
Line 409: done
--
To view, visit http://gerrit.ovirt.org/8175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ada84192a639c7780c40d7df62e22e3c9fa9e16
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Ryan Harper <ry...@us.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
