Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: failed validateAccess leaves pipes open ......................................................................
Patch Set 2: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/51850/2/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 29: import resource Line 30: import signal Line 31: import logging Line 32: import logging.config Line 33: from contextlib import closing > I think gathering the "from" imports together would be nicer. Since they ar long ago we decided that imports like this should be placed based on the order of contextlib.closing but yest, this sorting of this stanza is a random mess. Line 34: Line 35: from vdsm import commands Line 36: from vdsm import concurrent Line 37: from vdsm import cpuarch -- To view, visit https://gerrit.ovirt.org/51850 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6356837686c274389e92e828143cce3a5eeff564 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
