Piotr Kliczewski has posted comments on this change. Change subject: net: When IPv6 is not enabled, fallback to IPv4 ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/52366/1/vdsm/clientIF.py File vdsm/clientIF.py: Line 116: Line 117: host = config.get('addresses', 'management_ip') Line 118: port = config.getint('addresses', 'management_port') Line 119: Line 120: # When IPv6 is not enabled, fallback to listen on IPv4 address > Originally it was in the low level socket creation and then Dan remarked th It is hard for me to understand why clientIf should know anything about ipv4 vs ipv6. In my opinion this logic should be in different place. Line 121: try: Line 122: self._createAcceptor(host, port) Line 123: except socket.error as e: Line 124: if e.errno == errno.EAFNOSUPPORT and host in ('::', '::1'): -- To view, visit https://gerrit.ovirt.org/52366 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If95914dd9dfc88b40887345ac9e244ee2b1e09e9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
