Milan Zamazal has posted comments on this change. Change subject: virt: stats: make compute_latency more robust ......................................................................
Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/50593/9/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line 325: last_sample, last_index, mode): Line 326: operations = ( Line 327: last_sample['block.%d.%s.reqs' % (last_index, mode)] - Line 328: first_sample['block.%d.%s.reqs' % (first_index, mode)] Line 329: ) > I hate this style - please avoid it. I also prefer simpler expressions with subexpressions extracted into auxiliary variables, over complex multiline expressions with weird formatting. Line 330: if not operations: Line 331: return 0 Line 332: elapsed_time = ( Line 333: last_sample['block.%d.%s.times' % (last_index, mode)] - -- To view, visit https://gerrit.ovirt.org/50593 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4670309d48bd65a3afaba8124407598b76d808d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Milan Zamazal <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
