Marcin Mirecki has posted comments on this change. Change subject: supervdsm: moving nics between bonds ......................................................................
Patch Set 8: (5 comments) https://gerrit.ovirt.org/#/c/50596/8//COMMIT_MSG Commit Message: Line 7: supervdsm: > setupNetworks: Done Line 16: Example: > this example should be placed in a functional tests Done https://gerrit.ovirt.org/#/c/50596/8/lib/vdsm/network/api.py File lib/vdsm/network/api.py: Line 712: \ > no need for the trailing backslash inside parenthesis context. Added parenthesis context to conform to comment :) Done https://gerrit.ovirt.org/#/c/50596/8/lib/vdsm/network/configurators/iproute2.py File lib/vdsm/network/configurators/iproute2.py: Line 195: force > Please add a remark here, so we will not forget: Done Line 195: force > keep name across configurators Done -- To view, visit https://gerrit.ovirt.org/50596 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmire...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches