Francesco Romani has posted comments on this change. Change subject: migration: added support for convergance schedule ......................................................................
Patch Set 12: (1 comment) Well it is a suggestion, so if you think it doesn't make sense this is fine as well :) A possible meaningful split could be - one (or few) patch(es) makes the room for the new convergenceSchedule stuff, moving code around, introducing helper functions and so forth (e.g. moving code into _perform_with_downtime_thread) - one (or few) patch(es) adds the new convergenceSchedule stuff. Not sure this is what you meant in the last comment (maybe yes!) https://gerrit.ovirt.org/#/c/46940/12/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 342: self._startUnderlyingMigration(time.time()) Line 343: self._finishSuccessfully() Line 344: except libvirt.libvirtError as e: Line 345: if (e.get_error_code() == Line 346: libvirt.VIR_ERR_OPERATION_ABORTED): not sure why I didn't noticed before, but this looks unnecessary. Line 347: self.status = response.error( Line 348: 'migCancelErr', message='Migration canceled') Line 349: raise Line 350: except MigrationDestinationSetupError as e: -- To view, visit https://gerrit.ovirt.org/46940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
