Yaniv Bronhaim has posted comments on this change. Change subject: xmlrpc: retry when flushing socket ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/47637/6/vdsm/rpc/bindingxmlrpc.py File vdsm/rpc/bindingxmlrpc.py: Line 298: # such as the local error ECONNABORTED. Line 299: break Line 300: except SSL.SSLError as e: Line 301: if e.message != 'bad write retry': Line 302: break > The loop is there to make sure flush was run and it looks like it was a mis this sounds more easier to understand .. flushed = False while not flushed: try: wfile.flush() flushed = True except 1: # the failure is reasonable break except 2: if failure reasonable # the failure is reasonable break except: # maybe log? continue if not flushed: //log ? Line 303: Line 304: self.wfile.close() Line 305: self.rfile.close() Line 306: threadLocal.client = None -- To view, visit https://gerrit.ovirt.org/47637 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I52dd6ad304a82ff6c8d3dff12a38269684abf055 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
