Petr Horáček has uploaded a new change for review. Change subject: network: fix dhclient return code ......................................................................
network: fix dhclient return code Functions' output should be consistent. configurators/__init__.py:runDhclient() expects dhclient.start() to always return iterable of three values, but when we set blockingdhcp to False, start() returns just None and vdsm fails. Change-Id: I3fcc04504267b2d65a2aba7c5a5ebd74ed049582 Signed-off-by: Petr Horáček <[email protected]> --- M lib/vdsm/network/configurators/dhclient.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/53049/1 diff --git a/lib/vdsm/network/configurators/dhclient.py b/lib/vdsm/network/configurators/dhclient.py index 3e8f1fc..961bb8f 100644 --- a/lib/vdsm/network/configurators/dhclient.py +++ b/lib/vdsm/network/configurators/dhclient.py @@ -75,6 +75,7 @@ % self.iface) t.daemon = True t.start() + return 0, [], [] def shutdown(self): try: -- To view, visit https://gerrit.ovirt.org/53049 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3fcc04504267b2d65a2aba7c5a5ebd74ed049582 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
