Francesco Romani has posted comments on this change. Change subject: migration: added support for setting the convergenceSchedule ......................................................................
Patch Set 13: (1 comment) th https://gerrit.ovirt.org/#/c/47734/13/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7862: '*mode': 'MigrateMode', '*method': 'MigrateMethod', Line 7863: '*tunneled': 'bool', '*abortOnError': 'bool', Line 7864: 'consoleAddress': 'str', 'dstqemu': 'str', Line 7865: '*compressed': 'bool', '*autoConverge': 'bool', Line 7866: '*maxBandwidth': 'int', '*convergenceSchedule': 'str'}} > not documentation, commit message I mean :) Since we don't have JSON type in the schema (do we?), i guess the detailed doc you added is good enough. Line 7867: Line 7868: ## Line 7869: # @VM.migrate: Line 7870: # -- To view, visit https://gerrit.ovirt.org/47734 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09818e6f3283880edb704cb77c1f716392b11abe Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
