Antoni Segura Puimedon has posted comments on this change.
Change subject: Make nics, vlan and bonding dhcp ifup to be asynchronous.
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 917: # bridge -> vlan -> bond -> nic
Line 918: # For lower level devices we should ignore it.
Line 919: # reset ip, netmask, gateway and bootproto for lower level
devices
Line 920: bridgeIfup = partial(
Line 921: ifup, network, async=options.get('bootproto') and not
blockingDhcp)
I don't care much which style we choose. Patchset 2 or Patchset 3 have the same
behavior. So I will make final whatever people like more.
Line 922: ipaddr = netmask = gateway = options['bootproto'] = None
Line 923:
Line 924: # For VLAN we should attach bridge only to the VLAN device
Line 925: # rather than to underlying NICs or bond
Line 977: if bridged:
Line 978: bridgeIfup()
Line 979:
Line 980: # add libvirt network
Line 981: configWriter.createLibvirtNetwork(network, bridged, iface)
Totally right. I missed that.
Line 982:
Line 983: def assertBridgeClean(bridge, vlan, bonding, nics):
Line 984: brifs = os.listdir('/sys/class/net/%s/brif/' % bridge)
Line 985: for nic in nics:
--
To view, visit http://gerrit.ovirt.org/8098
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I80f5bbfe5ba4dfcf8f7f29c21a60b0cc2e129cb0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
