Edward Haas has posted comments on this change. Change subject: tests: Move network tests to its own folder ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/53704/5/vdsm.spec.in File vdsm.spec.in: Line 1226: %{_datadir}/%{vdsm_name}/tests/ip_route_show_table_all.out Line 1227: %{_datadir}/%{vdsm_name}/tests/iscsiadm_-m_iface.out Line 1228: %{_datadir}/%{vdsm_name}/tests/lvs_3386c6f2-926f-42c4-839c-38287fac8998.out Line 1229: %{_datadir}/%{vdsm_name}/tests/mem_info.out Line 1230: %{_datadir}/%{vdsm_name}/tests/network/*.py* > I'd prefer to have a line for each file to avoid mistakes at least in spec I think that forgetting to add a file here can be a more common mistake. This way we deploy everything and won't miss. Line 1231: %{_datadir}/%{vdsm_name}/tests/network/netmaskconversions Line 1232: %{_datadir}/%{vdsm_name}/tests/network/tc_filter_show.out Line 1233: %{_datadir}/%{vdsm_name}/tests/run_tests.sh Line 1234: %{_datadir}/%{vdsm_name}/tests/toolTests_empty.conf -- To view, visit https://gerrit.ovirt.org/53704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35031fd50d0451c6321bdf8eee28127422bedafe Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
