Martin Betak has posted comments on this change.

Change subject: migration: Add retry on full capacity
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/52799/14/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 601:         self._vm.log.debug('stopping migration monitor thread')
Line 602:         self._stop.set()
Line 603: 
Line 604: 
Line 605: def is_retry_error(result):
> let's figure out a nicer helper to be put in the response module
would something like https://gerrit.ovirt.org/#/c/46971/15/lib/vdsm/response.py 
with your comment addressed acceptable?
Line 606:     return result['status']['code'] == \


-- 
To view, visit https://gerrit.ovirt.org/52799
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I988fa2e501eb77d121668b22cc533b744a3dc755
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org>
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to