Martin Betak has posted comments on this change. Change subject: migration: Add DynamicThrottling semaphores ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/53304/11/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 157: Line 158: def __exit__(self, exc_type, exc_val, exc_tb): Line 159: self.release() Line 160: Line 161: def set_bound(self, value): I'm considering if it wouldn't be nicer if the bound was a property with this being it's setter and also a simple getter so outside world could easily read what the current bound setting is and also set it (perhaps more clearly?) as semaphore.bound = 5 rather than semaphore.set_bound(5) Line 162: """ Dynamically updates semaphore bound. Line 163: Line 164: When the the specified value is larger than the previous bound, Line 165: it releases the semaphore the required number of times (and possibly -- To view, visit https://gerrit.ovirt.org/53304 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
