Martin Betak has posted comments on this change. Change subject: response: Add support for specific error checking in is_error ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/54036/1/tests/responseTests.py File tests/responseTests.py: Line 74: self.assertEqual(res[key], args[key]) Line 75: Line 76: def test_is_error(self): Line 77: NAME = 'noVM' # no special meaning, any error is fine Line 78: NAME2 = 'hookError' > let's add a specific testcase for this new code path Done Line 79: self.assertTrue(response.is_error(response.error(NAME))) Line 80: Line 81: self.assertTrue(response.is_error(response.error(NAME), err=NAME)) Line 82: self.assertFalse(response.is_error(response.error(NAME), err=NAME2)) -- To view, visit https://gerrit.ovirt.org/54036 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00d8d2914983f75293ece5ce05894ca3821b7b24 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
