Edward Haas has posted comments on this change. Change subject: net: api: move legacy network handling to a separate module ......................................................................
Patch Set 13: (2 comments) https://gerrit.ovirt.org/#/c/54097/13/lib/vdsm/network/legacy_switch.py File lib/vdsm/network/legacy_switch.py: > aha, i was thinking about NetSwitch as a format for switches (OVS_switch, l handle, tool, util, process verbs are big, heavy and say nothing informative... so I try to avoid them. Dan mentioned that netswitch calling *_switch is ok. Future netswitch should do switching between switch types and the switch type should do switching between its configurators. Line 1: # Copyright 2011-2015 Red Hat, Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by https://gerrit.ovirt.org/#/c/54097/13/tests/functional/networkTests.py File tests/functional/networkTests.py: > And OVS specific. Not sure I understand how separated files can increase the chance someone will break something.. To reduce the risk of breaking things, we should try to convert tests to switch agnostic, such that the assert will be done per the switch type, not the high level logic. BTW: I dislike the Skip test thing in general :) We run the test and we control the env, all switches should be available. Line 1: # Line 2: # Copyright 2013-2016 Red Hat, Inc. Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License as published by -- To view, visit https://gerrit.ovirt.org/54097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I318df0fcf061322d8337465d9248b90dcec3db59 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
